legop3/MultiRoombaRover
1
0
Fork 0
mirror of https://github.com/legop3/MultiRoombaRover.git synced 2026-09-16 01:21:20 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity

show original chat message

Browse Source
This commit is contained in:
legop3
2026-06-19 23:26:26 -04:00
parent f0a7d72f94
commit 9cf44b316d
2 changed files with 20 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files
server/src/services/chatService/handlers.js
+16 -15
View File
@@ -25,21 +25,6 @@ function createHandlers({ sendSystemMessage }) {
// where an external API or rover-side feature has a real hard limit.
if (hasProfanity(clean)) return cb({ error: 'Message blocked' });
try {
const consumedAsCommand = await runChatTextCommand({ text: clean, socket, sendSystemMessage });
if (consumedAsCommand) {
cb({ success: true, command: true });
return;
}
} catch (err) {
// Command errors are returned through the existing chat acknowledgement
// contract. This keeps command execution server-side and avoids adding a
// new client pathway just to display failures.
logger.warn('Chat command failed', { socket: socket?.id, error: err.message });
cb({ error: err.message || 'Command failed' });
return;
}
const roverId = resolveRoverId(socket?.id);
const ttsOptions = normalizeTtsOptions(tts);
const message = buildMessage(socket, clean, {
@@ -64,6 +49,22 @@ function createHandlers({ sendSystemMessage }) {
broadcastMessage(message);
maybeSendAccessNotice(message, sendSystemMessage);
maybeSpeak(socket, message, ttsOptions);
try {
// Commands sent from site chat should still be visible as normal chat
// messages. Running the command after broadcast preserves the user-visible
// transcript while keeping permissions and command execution entirely on
// the server.
const ranCommand = await runChatTextCommand({ text: clean, socket, sendSystemMessage });
cb({ success: true, command: ranCommand });
return;
} catch (err) {
logger.warn('Chat command failed after broadcast', { socket: socket?.id, error: err.message });
sendSystemMessage(`Command failed: ${err.message || 'unknown error'}`, { nickname: 'Rover bot', bot: true });
cb({ success: true, command: true, commandError: err.message || 'Command failed' });
return;
}
cb({ success: true });
}