stupid

server/src/helpers/dataPaths.js

@@ -0,0 +1,41 @@
+// data Paths helper
+// Purpose: Resolves persistent data paths across refactors so services keep loading prior state files.
+// Scope: Preserves runtime behavior by preferring configured/canonical paths while supporting legacy locations.
+const fs = require('fs');
+const path = require('path');
+
+const CANONICAL_DATA_DIR = path.resolve(__dirname, '..', '..', 'data');
+const LEGACY_DATA_DIR = path.resolve(__dirname, '..', 'data');
+
+function pathExists(target) {
+  try {
+    fs.accessSync(target, fs.constants.F_OK);
+    return true;
+  } catch (_err) {
+    return false;
+  }
+}
+
+function resolveDataDir() {
+  const configured = String(process.env.SERVER_DATA_DIR || '').trim();
+  if (configured) return path.resolve(configured);
+  if (pathExists(CANONICAL_DATA_DIR)) return CANONICAL_DATA_DIR;
+  if (pathExists(LEGACY_DATA_DIR)) return LEGACY_DATA_DIR;
+  return CANONICAL_DATA_DIR;
+}
+
+function resolveDataPath(fileName) {
+  const configured = String(process.env.SERVER_DATA_DIR || '').trim();
+  if (configured) return path.join(path.resolve(configured), fileName);
+
+  const canonicalPath = path.join(CANONICAL_DATA_DIR, fileName);
+  const legacyPath = path.join(LEGACY_DATA_DIR, fileName);
+  if (pathExists(canonicalPath)) return canonicalPath;
+  if (pathExists(legacyPath)) return legacyPath;
+  return canonicalPath;
+}
+
+module.exports = {
+  resolveDataDir,
+  resolveDataPath,
+};

server/src/services/adminReasonService/index.js

@@ -2,14 +2,14 @@
 // Purpose: Defines the admin Reason Service module and the helpers/state used by this service unit.
 // Scope: Keeps runtime behavior unchanged while isolating responsibilities into a clear module boundary.
 const fs = require('fs');
-const path = require('path');
 const io = require('../../globals/io');
 const logger = require('../../globals/logger').child('adminReasonService');
 const { isAdmin } = require('../roleService');
 const { publishEvent } = require('../eventBus');
+const { resolveDataDir, resolveDataPath } = require('../../helpers/dataPaths');
 
-const DATA_DIR = path.join(__dirname, '..', '..', '..', 'data');
-const STORE_PATH = path.join(DATA_DIR, 'admin-reason.json');
+const DATA_DIR = resolveDataDir();
+const STORE_PATH = resolveDataPath('admin-reason.json');
 const MAX_REASON_LENGTH = 240;
 
 let cache = null;

server/src/services/audioLevelsService/index.js

@@ -2,18 +2,18 @@
 // Purpose: Defines the audio Levels Service module and the helpers/state used by this service unit.
 // Scope: Keeps runtime behavior unchanged while isolating responsibilities into a clear module boundary.
 const fs = require('fs');
-const path = require('path');
 const EventEmitter = require('events');
 const io = require('../../globals/io');
 const logger = require('../../globals/logger').child('audioLevelsService');
 const { loadConfig } = require('../../helpers/configLoader');
+const { resolveDataDir, resolveDataPath } = require('../../helpers/dataPaths');
 const { isAdmin } = require('../roleService');
 const roverManager = require('../roverManager');
 const { issueCommand } = require('../commandService');
 
 const audioLevelsEvents = new EventEmitter();
-const DATA_DIR = path.join(__dirname, '..', '..', '..', 'data');
-const STORE_PATH = path.join(DATA_DIR, 'audio-levels.json');
+const DATA_DIR = resolveDataDir();
+const STORE_PATH = resolveDataPath('audio-levels.json');
 const config = loadConfig();
 const configuredDefaults = config.audioLevels || {};
 

server/src/services/buttonBoxService/index.js

@@ -2,11 +2,11 @@
 // Purpose: Defines the button Box Service module and the helpers/state used by this service unit.
 // Scope: Keeps runtime behavior unchanged while isolating responsibilities into a clear module boundary.
 const fs = require('fs');
-const path = require('path');
 const express = require('express');
 const { app } = require('../../globals/http');
 const io = require('../../globals/io');
 const logger = require('../../globals/logger').child('buttonBoxService');
+const { resolveDataDir, resolveDataPath } = require('../../helpers/dataPaths');
 const { publishEvent } = require('../eventBus');
 const { getRewardById, listRewards } = require('../../rewards');
 const roverManager = require('../roverManager');
@@ -23,8 +23,8 @@ const {
 } = require('../homeAssistantService');
 const { getRequestIp, isLocalNetwork, normalizeIp } = require('../../helpers/ipResolver');
 
-const DATA_DIR = path.join(__dirname, '..', '..', '..', 'data');
-const STORE_PATH = path.join(DATA_DIR, 'buttonbox-state.json');
+const DATA_DIR = resolveDataDir();
+const STORE_PATH = resolveDataPath('buttonbox-state.json');
 const BUTTON_COUNT = 4;
 const STORE_VERSION = 1;
 

server/src/services/communityGoalService/index.js

@@ -2,14 +2,14 @@
 // Purpose: Defines the community Goal Service module and the helpers/state used by this service unit.
 // Scope: Keeps runtime behavior unchanged while isolating responsibilities into a clear module boundary.
 const fs = require('fs');
-const path = require('path');
 const io = require('../../globals/io');
 const logger = require('../../globals/logger').child('communityGoalService');
 const { isAdmin } = require('../roleService');
 const { publishEvent } = require('../eventBus');
+const { resolveDataDir, resolveDataPath } = require('../../helpers/dataPaths');
 
-const DATA_DIR = path.join(__dirname, '..', '..', '..', 'data');
-const STORE_PATH = path.join(DATA_DIR, 'community-goal.json');
+const DATA_DIR = resolveDataDir();
+const STORE_PATH = resolveDataPath('community-goal.json');
 const MAX_GOAL_LENGTH = 240;
 
 let cache = null;

server/src/services/discordGuildStore/index.js

@@ -2,11 +2,11 @@
 // Purpose: Defines the discord Guild Store module and the helpers/state used by this service unit.
 // Scope: Keeps runtime behavior unchanged while isolating responsibilities into a clear module boundary.
 const fs = require('fs');
-const path = require('path');
 const logger = require('../../globals/logger').child('discordGuildStore');
+const { resolveDataDir, resolveDataPath } = require('../../helpers/dataPaths');
 
-const DATA_DIR = path.join(__dirname, '..', '..', '..', 'data');
-const STORE_PATH = path.join(DATA_DIR, 'discord-guilds.json');
+const DATA_DIR = resolveDataDir();
+const STORE_PATH = resolveDataPath('discord-guilds.json');
 const VALID_MODES = new Set(['global', 'private']);
 
 let cache = null;

server/src/services/llmCommentaryService/index.js

@@ -13,7 +13,7 @@ const { getActiveDrivers } = require('../turnService');
 const { getNickname } = require('../nicknameService');
 const { getRecentMessages, sendSystemMessage } = require('../chatService');
 
-const PROMPT_PATH = path.join(__dirname, '..', '..', 'prompts', 'commentary_system.txt');
+const PROMPT_PATH = path.join(__dirname, '..', '..', '..', 'prompts', 'commentary_system.txt');
 const DEFAULT_FREQUENCY_MS = 0;
 const MIN_FREQUENCY_MS = 0;
 const JITTER_MS = 0;

server/src/services/replayEngineV2/index.js

@@ -15,12 +15,13 @@ const io = require('../../globals/io');
 const { getActiveDrivers } = require('../turnService');
 const { getNickname } = require('../nicknameService');
 const { getRecentMessages } = require('../chatService');
+const { resolveDataDir } = require('../../helpers/dataPaths');
 const sharp = require('sharp');
 
 const execFileAsync = promisify(execFile);
 
 const FFMPEG_BIN = process.env.FFMPEG_BIN || 'ffmpeg';
-const SEGMENT_ROOT = path.resolve(__dirname, '..', '..', '..', 'data', 'replay-segments');
+const SEGMENT_ROOT = path.join(resolveDataDir(), 'replay-segments');
 const SEGMENT_SECONDS = Math.max(1, Number.parseInt(process.env.REPLAY_SEGMENT_SECONDS || '1', 10));
 const BUFFER_SECONDS = Math.max(20, Number.parseInt(process.env.REPLAY_BUFFER_SECONDS || '45', 10));
 const CLEANUP_INTERVAL_MS = 10_000;

server/src/services/verificationService/index.js

@@ -1,12 +1,12 @@
 // verification Service
 // Purpose: Defines the verification Service module and the helpers/state used by this service unit.
 // Scope: Keeps runtime behavior unchanged while isolating responsibilities into a clear module boundary.
-const path = require('path');
 const crypto = require('crypto');
 const net = require('net');
 const EventEmitter = require('events');
 const io = require('../../globals/io');
 const logger = require('../../globals/logger').child('verificationService');
+const { resolveDataPath } = require('../../helpers/dataPaths');
 const { publishEvent } = require('../eventBus');
 const { normalizeIp } = require('../../helpers/ipResolver');
 const { getNickname, setNickname } = require('../nicknameService');
@@ -20,8 +20,7 @@ const {
   createJsonStore,
 } = require('../identityService');
 
-const DATA_DIR = path.join(__dirname, '..', '..', '..', 'data');
-const STORE_PATH = path.join(DATA_DIR, 'verified-users.json');
+const STORE_PATH = resolveDataPath('verified-users.json');
 
 const verificationEvents = new EventEmitter();